A comprehensive guide to effective code reviewing based on two decades of experience. Emphasizes focusing on big picture design over syntax, the critical importance of good naming, being decisive when rejecting changes, and treating reviews as iterative communication processes. Key principles include running code locally when

10m read timeFrom endler.dev
Post cover image
Table of contents
Think About The Big PictureNaming Is EverythingDon’t Be Afraid To Say “No”Code Review Is CommunicationUse Multiple Iterations Of ReviewsDon’t Be A JerkIf Possible, Try To Run The CodeBe Upfront About Your AvailabilityNever Stop LearningDon’t Be NitpickyFocus On The Why, Not The HowDon’t Be Afraid To Ask Stupid QuestionsAsk For Feedback On Your Reviewing Style
20 Comments

Sort: